Skip to content

Commit

Permalink
use a default values for the flows setting (helm#10765)
Browse files Browse the repository at this point in the history
details: if the `flows` setting is left unset, node-red will default the
files it creates for new flows to match the hostname of the container
it's running under. This hostname is dynamic and changes with a pod
restart. As a result changes made and persisted will be lost.

By defaulting the `flows` value to some static value, we ensure that the
changes will persist between pod restarts (assuming using persistent
storage)

Signed-off-by: Jeff Billimek <[email protected]>
  • Loading branch information
billimek authored and k8s-ci-robot committed Jan 23, 2019
1 parent e135c03 commit cf70159
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion stable/node-red/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 0.19.4
description: Node-RED is flow-based programming for the Internet of Things
name: node-red
version: 1.0.1
version: 1.0.2
keywords:
- nodered
- node-red
Expand Down
2 changes: 1 addition & 1 deletion stable/node-red/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ The following tables lists the configurable parameters of the Sentry chart and t
| `image.repository` | node-red image | `nodered/node-red-docker` |
| `image.tag` | node-red image tag | `0.19.4-v8` |
| `image.pullPolicy` | node-red image pull policy | `IfNotPresent` |
| `flows` | Default flows configuration | `` |
| `flows` | Default flows configuration | `flows.json` |
| `nodeOptions` | Node.js runtime arguments | `` |
| `timezone` | Default timezone | `UTC` |
| `service.type` | Kubernetes service type for the GUI | `ClusterIP` |
Expand Down
2 changes: 1 addition & 1 deletion stable/node-red/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ image:
nameOverride: ""
fullnameOverride: ""

# flows: ""
flows: "flows.json"
# nodeOptions: ""
timezone: "UTC"

Expand Down

0 comments on commit cf70159

Please sign in to comment.