Data doesn't show up for published.wallet.xxx
#2
Assignees
Comments
This was referenced Dec 11, 2024
Merged
mergify bot
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Dec 11, 2024
_incidental_ refs: agoric-labs/vstorage-viewer#2 ## Description In the course of working on agoric-labs/vstorage-viewer#3 it was hard to work with an async `makeVstorageKit`. It was async because construction of the kit required fetching a bunch of data from vstorage to populate `agoricNames`. That concern is a higher level than vstorage so this pulls it out. That allows `makeVstorageKit` to be synchronous. I added a test of `makeAgoricNames` both before and after. Eventually I think something should make it easy to make an AgoricNamesKit that wraps `VstorageKit` the way `VstorageKit` wraps `Vstorage`. `makeWalletUtils` does that but needs more work. At least renaming to `SmartWallet` but it would help to have a rethink of the layering and vstorage decoding in client-utils. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations not documented but this will make it less complex ### Testing Considerations new test While refactoring, tsc really let me down by not detecting destuctured properies that were no longer on the source object. I suppose our settings aren't strict enough. I enabled `noImplicitAny` to detect those (by then filtering for makeVstorageKit) ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro steps:
Expected behavior:
Context:
Perhaps this has something to do with the fact that the node has data as well as children. When you go to a leaf node, like published.wallet.xxx.current, the data renders perfectly fine.
Screenshot
The text was updated successfully, but these errors were encountered: