Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential slow down in the simulation #92

Open
agrignard opened this issue Feb 17, 2020 · 14 comments
Open

Potential slow down in the simulation #92

agrignard opened this issue Feb 17, 2020 · 14 comments

Comments

@agrignard
Copy link
Owner

During the opening night, we have noticed a slow down in the speed of the simulation after few hours of running. It might be due to the last commit done in the 1 or 2 days before the opening (especially the one about the bike)

@tnguyenh before we forget it would be great to see if we can track this bug?
@tnguyenh
Copy link
Collaborator

Yes, I will have a look at it.

@agrignard
Copy link
Owner Author

@tnguyenh I know the project is kind of over but maybe it make sense to have a look on the last commit(s) done before the opening while it's still fresh in your head? I am not sure exactly how to reproduce the behavior we had during the opening

@agrignard
Copy link
Owner Author

I am trying to find what's the problem here but it's pretty hard to track.

So after one day (500k iteration) I start to see some lag (like sometimes one cycle out of 10ish would take like 1sec to execute) so we see a lag in the simu.

The memory is not too crazy though (700Mo) so I really don't know what's happening.

I will rerun a sim with Bikes to see if it comes from the last commit with the bikes

@tnguyenh
Copy link
Collaborator

Do you mean a sim without bikes ?

@agrignard
Copy link
Owner Author

without yes

@agrignard
Copy link
Owner Author

Good and bad news

Good news: It semes to wok normally without bike
Bad news: It means there is somethign wrong with the bike

If we can fix it quickly that will also faciliate the issue we have rigth now in the pavillon

@tnguyenh do you think you can have a look at your last commits concerning the bikes?

@ptaillandier
Copy link
Collaborator

ptaillandier commented Mar 3, 2020 via email

@agrignard
Copy link
Owner Author

on l'a déjà fait non ? line 518

loop j from: 0 to: stateNumber - 1{
			bike_graph[j] <- directed((as_edge_graph(bikelane where (each.allow_bikes[j])))) use_cache false;//with_weights weights_bikelane_sp;
			bike_graph[j] <- directed(bike_graph[j]);
		}
````

@ptaillandier
Copy link
Collaborator

ptaillandier commented Mar 5, 2020 via email

@agrignard
Copy link
Owner Author

Il est très chiant ce bug, je dirai que le fait de changer existat/vision devrait le favoriser mais j'ai du mal à le reproduire...

@tnguyenh
Copy link
Collaborator

tnguyenh commented Mar 5, 2020

De mon côté je n'arrive pas à le reproduire...

@agrignard
Copy link
Owner Author

Très très chiant ce bug. J'arrive à le reproduire la au bout de 150 000 iterations et je vois clairement une baisse dans le fps surtout au niveau de la transition mais j'ai fait pas mal de swithc entre avant et apres et activer/desactiver les layers...

@ptaillandier
Copy link
Collaborator

ptaillandier commented Mar 6, 2020 via email

@agrignard
Copy link
Owner Author

J'ai reussi à le reproduire un peu cette nuit en laissant tourner sur le mode vision la j'en suis a 280 000 iterations et il y a une petite pause dans la simu de temps en temps tout les dizaines de cycles mais ce n'est pas constant...

Aussi j'ai les deux displays image et simu peut etre que ca aurait une influence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ptaillandier @agrignard @tnguyenh