Made asyncio TaskGroup work with eager task factories #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Nov 13, 2024
|
Sigh...I improved my test and it's failing now. Back to the drawing board. |
CI looks green to me, what's failing? |
Fetching task state didn't work, as my amended test showed. I've pushed it now. |
graingert
reviewed
Nov 29, 2024
.pre-commit-config.yaml
Outdated
| @@ -22,14 +22,14 @@ repos: | |||
| - id: trailing-whitespace | |||
|
|
|||
| - repo: https://github.com/astral-sh/ruff-pre-commit | |||
| rev: v0.6.9 | |||
| rev: v0.7.1 | |||
There was a problem hiding this comment.
I think there's 0.8 out now?
Repository owner
deleted a comment from
graingert-coef
Nov 29, 2024
graingert
reviewed
Nov 29, 2024
agronholm
changed the title
graingert
reviewed
Nov 30, 2024
graingert
approved these changes
Nov 30, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #764.
This updates the task group code and type annotations to accommodate eager task factories.
Additionally, this updates pre-commit modules. The updated
mypycatches the annotation issues due to its updatedtypeshed.Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
* Fix big bad boo-boo in task groups (#123 <https://github.com/agronholm/anyio/issues/123>_; PR by @yourgithubaccount)If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.