Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: gulp dependencies in package.json #129

Merged
merged 1 commit into from
Oct 24, 2018
Merged

🐛 FIX: gulp dependencies in package.json #129

merged 1 commit into from
Oct 24, 2018

Conversation

KevinHuddy
Copy link
Contributor

Description

Fixed issue #128 by replacing "gulp": "github:gulpjs/gulp#4.0" with "gulp": "^4.0.0" in package.json

Screenshots:

screenshot 2018-10-23 12 58 33

Types of changes

FIX

How Has This Been Tested?

Tested by me locally on an active project.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has extensive inline documentation like the rest of WPGulp.

Copy link
Owner

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🔥

@ahmadawais ahmadawais merged commit 48e16ba into ahmadawais:master Oct 24, 2018
@ahmadawais ahmadawais changed the title 🚀 FIX: gulp dependencies in package.json 🐛 FIX: : gulp dependencies in package.json Oct 24, 2018
@ahmadawais ahmadawais changed the title 🐛 FIX: : gulp dependencies in package.json 🐛 FIX: gulp dependencies in package.json Oct 24, 2018
@parys-github
Copy link

Hi, guys, I am not really sure what is going on.
After the last update, wpgulp installing perfectly,
my styles are compressed properly but unfortunately vendor.js and custom.js still stay UnCompressed.
Do I need to create an extra task?
Seems to be right now both tasks for Vendor and Custom contain:
pipe( uglify() )
Any idea what is wrong?
Regards

@ahmadawais
Copy link
Owner

@parys-github kindly create a new issue and answer all the steps there are while you file a bug report.

@parys-github
Copy link

Thanks Ahmad, I will be very grateful for some advice on where to look for a solution.

@ahmadawais
Copy link
Owner

ahmadawais commented Oct 25, 2018

@parys-github sure but go here and file an issue with all the details mentioned there answered https://github.com/ahmadawais/WPGulp/issues/new?template=Bug_report.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants