enhance error handling in HTTP helpers; improve error messages for be…

…tter clarity
ahmedakef · Jan 8, 2025 · f3205b0 · f3205b0
1 parent e9afd7c
commit f3205b0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/frontend/src/Helpers/Http.elm b/frontend/src/Helpers/Http.elm
@@ -2,20 +2,27 @@ module Helpers.Http exposing (..)
 
 import Http
 
+
 errorToString : Http.Error -> String
 errorToString error =
     case error of
         Http.BadUrl url ->
             "The URL " ++ url ++ " was invalid"
+
         Http.Timeout ->
             "Unable to reach the server, try again"
+
         Http.NetworkError ->
             "Unable to reach the server, check your network connection"
+
         Http.BadStatus 500 ->
             "The server had a problem, try again later"
+
         Http.BadStatus 400 ->
             "Verify your information and try again"
-        Http.BadStatus _ ->
-            "Unknown error"
+
+        Http.BadStatus num ->
+            "Unknown error" ++ String.fromInt num
+
         Http.BadBody errorMessage ->
             errorMessage
diff --git a/frontend/src/Steps/Steps.elm b/frontend/src/Steps/Steps.elm
@@ -72,15 +72,15 @@ update msg state =
                             ( Success { successState | steps = steps }, Cmd.none )
 
                         Err err ->
-                            ( Failure (err |> HttpHelper.errorToString), Cmd.none )
+                            ( Failure ("error while getting program execution steps" ++ HttpHelper.errorToString err), Cmd.none )
 
                 GotSourceCode sourceCodeResult ->
                     case sourceCodeResult of
                         Ok sourceCode ->
                             ( Success { successState | sourceCode = sourceCode }, Cmd.none )
 
                         Err err ->
-                            ( Failure (err |> HttpHelper.errorToString), Cmd.none )
+                            ( Failure ("error while reading program source code" ++ HttpHelper.errorToString err), Cmd.none )
 
                 Next ->
                     if successState.position + 1 > List.length successState.steps then