Remove constraints from GitHub in constraints.txt

[spencerkclark]

#2267 added torch_harmonics via a GitHub URL to the pip-requirements.txt file, which subsequently led to it being used in the constraints.txt file. This broke the dataflow image build as newer versions of pip no longer allow this: #2304.

This PR implements the fix suggested in a discussion between @frodre and @oliverwm1 in Slack a while back:

Could we just avoid having it in the constraints entirely? It would still get installed in the image right?

Indeed it seems like even if older versions of pip allow GitHub URLs to appear in constraints files, they do not have the desired effect. In other words if one does:

$ pip install -c constraints.txt torch_harmonics

in an environment without it already installed, pip will download the latest version off of PyPI instead of fetching it from the GitHub URL in the constraints file (perhaps this is not surprising since it is unnamed and pip is not set up to infer the name from the URL). Thus I suppose it is somewhat misleading to include GitHub URLs in the constraints to begin with, and sufficient / better that we specify torch_harmonics from GitHub in the setup.py in xtorch_harmonics:

fv3net/external/xtorch_harmonics/setup.py

Line 16 in 314edd5

"torch_harmonics @ git+https://github.com/NVIDIA/torch-harmonics.git@8826246cacf6c37b600cdd63fde210815ba238fd", # noqa: E501

All that being said, I have implemented this in a way such to retain git+https://github.com/NVIDIA/torch-harmonics.git@8826246cacf6c37b600cdd63fde210815ba238fd in pip-requirements.txt since it appears pip-compile can still resolve dependencies from packages on GitHub and use that to inform the versions of other packages pinned in the constraints.txt file, which is still useful.

Requirement changes:

• Ran make lock_deps/lock_pip following these instructions

Resolves #2304

Coverage reports (updated automatically):

[oliverwm1]

Thanks for the fix. One minor suggestion.