Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename stage block types #8

Merged
merged 2 commits into from
Jan 10, 2025
Merged

refactor!: rename stage block types #8

merged 2 commits into from
Jan 10, 2025

Conversation

eegli
Copy link
Collaborator

@eegli eegli commented Jan 10, 2025 •
edited
Loading

  • Renames the stage blocks from TransformerBlockConfig to TransformerBlock, same for Mamba. This is much more intuitive
  • Removes unnecessary subclassing from BaseModel
  • Formats a few imports

It's only a breaking change in terms of imports for downstream users, no functionality is affected.

@eegli eegli requested a review from jannisborn January 10, 2025 09:22
jannisborn
jannisborn approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@jannisborn jannisborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we just need a patch or minor version bump

@eegli eegli merged commit d5163a3 into main Jan 10, 2025
6 checks passed
@eegli eegli deleted the rename-blocks branch January 10, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannisborn jannisborn jannisborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eegli @jannisborn