Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pipfile instead of requirements #1

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Use Pipfile instead of requirements #1

merged 1 commit into from
Jun 16, 2020

Conversation

tumido
Copy link
Member

@tumido tumido commented Jun 16, 2020

I've converted the requirements.txt to Pipfile so we can use the repo for the jupyter notebook images out of the box.

Dependencies are left unchanged, just listed in their appropriate categories.

@sefkhet-abwy sefkhet-abwy bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2020
@tumido
Copy link
Member Author

tumido commented Jun 16, 2020

cc @durandom @MichaelClifford

@sefkhet-abwy sefkhet-abwy bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
MichaelClifford
MichaelClifford approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MichaelClifford MichaelClifford merged commit ad62528 into aicoe-aiops:master Jun 16, 2020
@durandom
Copy link
Member

@4n4nd what do we need to do in order to make sesheta merge after approving?

@4n4nd
Copy link

4n4nd commented Jun 16, 2020

@durandom we are waiting for the bots to accept the invitation to join our org.
I think @goern needs to accept the invitations

@tumido tumido mentioned this pull request Jun 16, 2020
Closed
@MichaelClifford MichaelClifford mentioned this pull request Jan 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelClifford MichaelClifford MichaelClifford approved these changes

@durandom durandom durandom approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tumido @durandom @4n4nd @MichaelClifford