Merge pull request #18 from aidanmelen/v1.2.0

added default name tag. added confluent managed rules

Makefile

@@ -1,7 +1,7 @@
 NAME := security-group-v2
 HOSTNAME := aidanmelen
 PROVIDER := aws
-VERSION := 1.1.0
+VERSION := 1.2.0
 SHELL := /bin/bash
 
 

README.md

@@ -25,7 +25,7 @@ Create a Security Group with the following rules:
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = "Allow TLS inbound traffic"
@@ -42,10 +42,6 @@ module "security_group" {
   egress = [
     { rule = "all-all-to-public" }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }
 ```
 
@@ -88,15 +84,15 @@ Run Terratest using the [Makefile](https://github.com/aidanmelen/terraform-aws-s
 ### Results
 
 ```
-Terratest Suite (v1.1.0)
---- PASS: TestTerraformBasicExample (23.48s)
---- PASS: TestTerraformCompleteExample (49.69s)
---- PASS: TestTerraformCustomerRulesExample (36.73s)
---- PASS: TestTerraformManagedRulesExample (36.19s)
+Terratest Suite (v1.2.0)
+--- PASS: TestTerraformBasicExample (24.12s)
+--- PASS: TestTerraformCompleteExample (50.08s)
+--- PASS: TestTerraformCustomerRulesExample (34.89s)
+--- PASS: TestTerraformManagedRulesExample (33.99s)
 --- PASS: TestTerraformCommonRulesExample (27.24s)
---- PASS: TestTerraformMatrixRulesExample (34.10s)
---- PASS: TestTerraformComputedRulesExample (46.96s)
---- PASS: TestTerraformRulesOnlyExample (22.63s)
+--- PASS: TestTerraformMatrixRulesExample (34.88s)
+--- PASS: TestTerraformComputedRulesExample (41.59s)
+--- PASS: TestTerraformRulesOnlyExample (22.57s)
 ```
 
 ## Makefile Targets

examples/basic/.main.tf.docs

@@ -1,7 +1,7 @@
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = "Allow TLS inbound traffic"
@@ -18,8 +18,4 @@ module "security_group" {
   egress = [
     { rule = "all-all-to-public" }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/basic/README.md

@@ -27,7 +27,7 @@ Note that this example may create resources which cost money. Run `terraform des
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = "Allow TLS inbound traffic"
@@ -44,10 +44,6 @@ module "security_group" {
   egress = [
     { rule = "all-all-to-public" }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }
 ```
 

examples/basic/main.tf

@@ -17,8 +17,4 @@ module "security_group" {
   egress = [
     { rule = "all-all-to-public" }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/common/.main.tf.docs

@@ -2,34 +2,26 @@
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "public_https_sg" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = "${local.name}-https"
   description = "${local.name}-https"
   vpc_id      = data.aws_vpc.default.id
 
   ingress = [{ rule = "https-tcp-from-public" }, { rule = "all-all-from-self" }]
   egress  = [{ rule = "all-all-to-public" }]
-
-  tags = {
-    "Name" = "${local.name}-https"
-  }
 }
 
 #tfsec:ignore:aws-vpc-no-public-ingress-sgr
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "public_http_sg" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = "${local.name}-http"
   description = "${local.name}-http"
   vpc_id      = data.aws_vpc.default.id
 
   ingress = [{ rule = "http-tcp-from-public" }, { rule = "all-all-from-self" }]
   egress  = [{ rule = "all-all-to-public" }]
-
-  tags = {
-    "Name" = "${local.name}-http"
-  }
 }

examples/common/README.md

@@ -27,36 +27,28 @@ Note that this example may create resources which cost money. Run `terraform des
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "public_https_sg" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = "${local.name}-https"
   description = "${local.name}-https"
   vpc_id      = data.aws_vpc.default.id
 
   ingress = [{ rule = "https-tcp-from-public" }, { rule = "all-all-from-self" }]
   egress  = [{ rule = "all-all-to-public" }]
-
-  tags = {
-    "Name" = "${local.name}-https"
-  }
 }
 
 #tfsec:ignore:aws-vpc-no-public-ingress-sgr
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "public_http_sg" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = "${local.name}-http"
   description = "${local.name}-http"
   vpc_id      = data.aws_vpc.default.id
 
   ingress = [{ rule = "http-tcp-from-public" }, { rule = "all-all-from-self" }]
   egress  = [{ rule = "all-all-to-public" }]
-
-  tags = {
-    "Name" = "${local.name}-http"
-  }
 }
 ```
 

examples/common/main.tf

@@ -9,10 +9,6 @@ module "public_https_sg" {
 
   ingress = [{ rule = "https-tcp-from-public" }, { rule = "all-all-from-self" }]
   egress  = [{ rule = "all-all-to-public" }]
-
-  tags = {
-    "Name" = "${local.name}-https"
-  }
 }
 
 #tfsec:ignore:aws-vpc-no-public-ingress-sgr
@@ -26,8 +22,4 @@ module "public_http_sg" {
 
   ingress = [{ rule = "http-tcp-from-public" }, { rule = "all-all-from-self" }]
   egress  = [{ rule = "all-all-to-public" }]
-
-  tags = {
-    "Name" = "${local.name}-http"
-  }
 }

examples/complete/.main.tf.docs

@@ -2,7 +2,7 @@
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -104,6 +104,6 @@ module "security_group" {
 
 module "disabled_sg" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
   create = false
 }

examples/complete/README.md

@@ -31,7 +31,7 @@ Note that this example may create resources which cost money. Run `terraform des
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -133,7 +133,7 @@ module "security_group" {
 
 module "disabled_sg" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
   create = false
 }
 ```

examples/computed/.main.tf.docs

@@ -29,7 +29,7 @@ resource "aws_ec2_managed_prefix_list" "other" {
 
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -83,8 +83,4 @@ module "security_group" {
     rules                    = [{ rule = "postgresql-tcp" }],
     source_security_group_id = aws_security_group.other.id
   }
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/computed/README.md

@@ -52,7 +52,7 @@ resource "aws_ec2_managed_prefix_list" "other" {
 
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -106,10 +106,6 @@ module "security_group" {
     rules                    = [{ rule = "postgresql-tcp" }],
     source_security_group_id = aws_security_group.other.id
   }
-
-  tags = {
-    "Name" = local.name
-  }
 }
 ```
 

examples/computed/main.tf

@@ -82,8 +82,4 @@ module "security_group" {
     rules                    = [{ rule = "postgresql-tcp" }],
     source_security_group_id = aws_security_group.other.id
   }
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/customer/.main.tf.docs

@@ -2,7 +2,7 @@
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -73,8 +73,4 @@ module "security_group" {
       self      = true
     }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/customer/README.md

@@ -25,7 +25,7 @@ Note that this example may create resources which cost money. Run `terraform des
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -96,10 +96,6 @@ module "security_group" {
       self      = true
     }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }
 ```
 

examples/customer/main.tf

@@ -72,8 +72,4 @@ module "security_group" {
       self      = true
     }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/managed/.main.tf.docs

@@ -2,7 +2,7 @@
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -53,8 +53,4 @@ module "security_group" {
       self = true
     }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/managed/README.md

@@ -25,7 +25,7 @@ Note that this example may create resources which cost money. Run `terraform des
 #tfsec:ignore:aws-ec2-no-public-egress-sgr
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name        = local.name
   description = local.name
@@ -76,10 +76,6 @@ module "security_group" {
       self = true
     }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }
 ```
 

examples/managed/main.tf

@@ -52,8 +52,4 @@ module "security_group" {
       self = true
     }
   ]
-
-  tags = {
-    "Name" = local.name
-  }
 }

examples/matrix/.main.tf.docs

@@ -1,6 +1,6 @@
 module "security_group" {
   source  = "aidanmelen/security-group-v2/aws"
-  version = ">= 1.1.0"
+  version = ">= 1.2.0"
 
   name   = local.name
   vpc_id = data.aws_vpc.default.id
@@ -28,8 +28,4 @@ module "security_group" {
     cidr_blocks              = ["10.0.0.0/24", "10.0.1.0/24"]
     source_security_group_id = data.aws_security_group.default.id
   }
-
-  tags = {
-    "Name" = local.name
-  }
 }