Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated contributing guide #520

Merged
merged 7 commits into from
Aug 13, 2023

Conversation

Timonwa
Copy link
Contributor

@Timonwa Timonwa commented Aug 12, 2023

Please describe the changes this PR makes and why it should be merged:

  • I updated the contributing guide.
  • @aidenybai @tobySolutions I left some questions below that need clarification. Please go through them and give me an answer.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2023

CLA assistant check
All committers have signed the CLA.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5844039832

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.986%

Totals Coverage Status
Change from base Build 5839929543: 0.0%
Covered Lines: 1219
Relevant Lines: 4882

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 5844039832

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.986%

Totals Coverage Status
Change from base Build 5839929543: 0.0%
Covered Lines: 1219
Relevant Lines: 4882

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants