Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculator example added #559

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Calculator example added #559

merged 4 commits into from
Aug 28, 2023

Conversation

oliverloops
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
A new example added to kitchen sink, extending Million's use cases

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2023 11:48pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2023 11:48pm

@coveralls
Copy link

coveralls commented Aug 26, 2023

Pull Request Test Coverage Report for Build 5993866936

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.968%

Totals Coverage Status
Change from base Build 5989436660: 0.0%
Covered Lines: 1267
Relevant Lines: 5074

💛 - Coveralls

@aidenybai
Copy link
Owner

@oliverloops amazing work! make sure to format w/ prettier + wrap the Screen component in a block

@oliverloops
Copy link
Contributor Author

Sure!, I'll update the PR soon

@oliverloops
Copy link
Contributor Author

I already formatted with prettier and added the block to Screen component. I also I added a react bare bones todo list example to complement

@aidenybai
Copy link
Owner

amazing work @oliverloops

@aidenybai aidenybai merged commit ef75e4d into aidenybai:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants