Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Upload and Preview #637

Merged
merged 4 commits into from
Oct 4, 2023
Merged

File Upload and Preview #637

merged 4 commits into from
Oct 4, 2023

Conversation

darshbaxi
Copy link
Contributor

@darshbaxi darshbaxi commented Oct 2, 2023 •
edited
Loading

Fixes: #623
I have made the file upload and preview app in which users can upload files and preview those files. I developed it using the block of million.js.
image
image

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:08pm
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:08pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:08pm

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

deeola
deeola reviewed Oct 2, 2023
View reviewed changes
packages/kitchen-sink/src/examples/file-upload-preview.jsx Outdated
}

const FileUpload=block(({file})=>{
console.log(file)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you left this here😉

packages/kitchen-sink/src/examples/file-upload-preview.jsx Outdated
console.log(file)
return(
<div className='preview' >
<img src={file} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have an 'alt' too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,I will fix this:)

@darshbaxi darshbaxi requested a review from deeola October 2, 2023 16:06
@darshbaxi
Copy link
Contributor Author

@deeola suggested changes made. please review it again:)

@aidenybai
Copy link
Owner

Please run pnpm run cleanup

@darshbaxi
Copy link
Contributor Author

@aidenybai requirement satisfy to run 'pnpm -w run cleanup' command. please review it again:)

@tobySolutions
Copy link
Contributor

Have you worked on the requested changes @deeola?

@darshbaxi
Copy link
Contributor Author

@tobySolutions Yes, I made the all requested changes suggested.

tobySolutions
tobySolutions suggested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate the components? It's not really best practice to nest components. Thank you.

@darshbaxi
Copy link
Contributor Author

darshbaxi commented Oct 3, 2023 •
edited
Loading

@tobySolutions Required changes made, please review it again:)
Thank you

darshbaxi
darshbaxi commented Oct 4, 2023
View reviewed changes
Copy link
Contributor Author

@darshbaxi darshbaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobySolutions,I made the suggested changes:)

tobySolutions
tobySolutions approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobySolutions tobySolutions merged commit 5b29e40 into aidenybai:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobySolutions tobySolutions tobySolutions approved these changes

@deeola deeola Awaiting requested review from deeola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A File Upload and Preview Component
5 participants
@darshbaxi @CLAassistant @aidenybai @tobySolutions @deeola