Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/kitchen sink example of task tracker with drag and drop #710

Merged
merged 14 commits into from
Oct 14, 2023
Merged

Feat/kitchen sink example of task tracker with drag and drop #710

merged 14 commits into from
Oct 14, 2023

Conversation

devhd9
Copy link
Contributor

@devhd9 devhd9 commented Oct 8, 2023 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Task-Tracker with drag and drop example added for kitchen sink. Which refers to issue #602.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Sample video of example

Screen.Recording.2023-10-08.at.11.47.26.PM.mov

devhd9 added 11 commits October 8, 2023 23:05
@devhd9
feat: Basic structure created
56d5d4b
@devhd9
feat: created add task functionality
078ead7
@devhd9
feat: created feature of editing list item
9c5988b
@devhd9
feat: added color prop for icon color
d7545a3
@devhd9
fix: UI improvements
74d6d39 
Made small improvements in spacing, spacing units, colors
@devhd9
feat: added uniqueId property in each list item object
e77b083
@devhd9
feat: added package @hello-pangea/dnd
0c1580e 
this is an alternative package to react-beautiful-dnd. react-beautiful-dnd is no longer getting maintained for now. So many issues are there. @hello-pangea/dnd package is nothing but react-beautiful-dnd with issues fixed.
@devhd9
feat: created drag-and-drop feature
fad4924
@devhd9
feat: wrapped components with block HOC
48dfbe1
@devhd9
feat: added For component for looping component
5232cf3
@devhd9
feat: added response for enter key pressed when adding new item
c1a9888
@vercel
Copy link

vercel bot commented Oct 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:24am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:24am

Timonwa
Timonwa approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Timonwa Timonwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I have only one suggestion. Can the To Do text be red, In Progress be yellow, and Completed be green?

@devhd9
Copy link
Contributor Author

devhd9 commented Oct 9, 2023 •
edited
Loading

Hey @Timonwa, thanks for the suggestion. I have applied changes, kindly check it.

@Timonwa
Copy link
Contributor

Timonwa commented Oct 10, 2023

@devhd9 , awesome. 👍🏽
@tobySolutions is ready to be merged.

tobySolutions
tobySolutions reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @devhd9. Could you maybe fix the mobile view?

Screenshot 2023-10-10 at 08 26 27

@tobySolutions
Copy link
Contributor

Any updates on this @devhd9?

@devhd9
Copy link
Contributor Author

devhd9 commented Oct 12, 2023

Hi @tobySolutions, apologies for the delay, I was occupied earlier. I have made changes. Kindly review it.

@tobySolutions
Copy link
Contributor

Hi @tobySolutions, apologies for the delay, I was occupied earlier. I have made changes. Kindly review it.

Awesome! Taking a look now.

tobySolutions
tobySolutions approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@tobySolutions tobySolutions merged commit ab34113 into aidenybai:main Oct 14, 2023
3 checks passed
@tobySolutions tobySolutions mentioned this pull request Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobySolutions tobySolutions tobySolutions approved these changes

@Timonwa Timonwa Timonwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devhd9 @Timonwa @tobySolutions