Build a virtual whiteboard 613 #742
Merged
+431
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
There was a problem hiding this comment.
Hey there @one2code, you didn't use the block() function from Million at all 🤔
|
I'm gonna merge this for now, though. |
|
@tobySolutions Is it ok to create another PR with updates? I also found a bug as well. |
|
Please go for it @one2code; sorry I think some things I pushed earlier messed up the repo and your PR. Go ahead and make another PR please. Make sure to use more of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Designed and created a virtual whiteboard with in React-TS with Million.js, that allows the user to select their input color and the modes: draw, write, line, erase, undo, and redo. This fulfills the criteria laid out in #613, as part of Million.js 's Hacktoberfest event.
I made a further commit to resolve issues with the way the color input button was being rendered in Chrome vs Firefox. In Chrome, padding was being added by default that crushed the visibility of the selected color inside of the button. I added values specific to Chrome and Firefox to make the button look similar between the two browsers for a more consistent user experience.
Status
Semantic versioning classification: