Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fat_bands=True when FatBands is required #1023

Conversation

AndresOrtegaGuerrero
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Dec 23, 2024

This closes #1020

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (d4c495e) to head (7c233e8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   68.86%   69.17%   +0.31%     
==========================================
  Files         115      115              
  Lines        6462     6463       +1     
==========================================
+ Hits         4450     4471      +21     
+ Misses       2012     1992      -20     
Flag Coverage Δ
python-3.11 69.17% <100.00%> (+0.31%) ⬆️
python-3.9 69.18% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 219b06e into aiidalab:main Dec 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'fat bands' checkbox should be selected by default, if the user requested fat bands in the input
2 participants