Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate waiting workflow state to running #1077

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

edan-bainglass
Copy link
Member

This PR simply translates "WAITING" states to "RUNNING", since workflows "always" WAIT on RUNNING calculations. This makes it more clear to the user that things are running. Workflows awaiting other calculations are in a "QUEUED" state.

@edan-bainglass edan-bainglass self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.50%. Comparing base (f80ae9a) to head (1329722).

Files with missing lines Patch % Lines
src/aiidalab_qe/common/panel.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   69.11%   69.50%   +0.38%     
==========================================
  Files         113      113              
  Lines        6764     6768       +4     
==========================================
+ Hits         4675     4704      +29     
+ Misses       2089     2064      -25     
Flag Coverage Δ
python-3.11 69.48% <75.00%> (+0.38%) ⬆️
python-3.9 69.52% <75.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass requested review from AndresOrtegaGuerrero and removed request for superstar54 January 13, 2025 07:35
@edan-bainglass edan-bainglass merged commit 2092568 into aiidalab:main Jan 13, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants