Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize external resource setup notebook for code management #986

Merged

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Dec 17, 2024

This PR provides a top level button and a link in step 3 to the new external resource setup notebook in aiidalab-home (aiidalab/aiidalab-home#188). It also removes the code setup widget buttons from the individual code selectors in step 3 (in favor of the external notebook).

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.99%. Comparing base (416fb6f) to head (e563af8).

Files with missing lines Patch % Lines
src/aiidalab_qe/common/panel.py 50.00% 4 Missing ⚠️
src/aiidalab_qe/app/submission/__init__.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   67.99%   67.99%   -0.01%     
==========================================
  Files         113      113              
  Lines        6734     6740       +6     
==========================================
+ Hits         4579     4583       +4     
- Misses       2155     2157       +2     
Flag Coverage Δ
python-3.11 67.99% <62.50%> (-0.01%) ⬇️
python-3.9 68.01% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass
Copy link
Member Author

Hi @superstar54. If you're interested, take a look at the last commit. I moved some stuff around to better fit our overall MVC approach.

@danielhollas danielhollas removed their request for review December 19, 2024 09:21
@edan-bainglass edan-bainglass force-pushed the external-code-setup-notebook branch 2 times, most recently from 84a056a to 64fbdb4 Compare December 20, 2024 10:03
@edan-bainglass
Copy link
Member Author

edan-bainglass commented Dec 20, 2024

@yakutovicha can you say more regarding reasons for previously moving from external code setup to in-line widgets?

@edan-bainglass edan-bainglass force-pushed the external-code-setup-notebook branch 11 times, most recently from 80e2552 to ca7a4a5 Compare December 26, 2024 09:02
@edan-bainglass edan-bainglass force-pushed the external-code-setup-notebook branch 2 times, most recently from af90592 to 873eb24 Compare December 30, 2024 17:34
@edan-bainglass edan-bainglass force-pushed the external-code-setup-notebook branch 3 times, most recently from e4da5f9 to 6a33aa1 Compare January 10, 2025 16:25
@edan-bainglass edan-bainglass force-pushed the external-code-setup-notebook branch 2 times, most recently from ac2acce to bbfc57c Compare January 13, 2025 09:38
@edan-bainglass edan-bainglass force-pushed the external-code-setup-notebook branch from bbfc57c to 09b1dec Compare January 13, 2025 12:49
@edan-bainglass
Copy link
Member Author

@yakutovicha no response 😔 If okay with you, can we proceed with this PR? We can revisit in-app code setup widgets later, perhaps when the widget is in a better, lazy-loaded state. Note that we (Giovanni, Carlo, and I) have been discussion revamping the widget entirely. Let's see.

@edan-bainglass
Copy link
Member Author

@superstar54 can we approve this one?

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It's very alloying that there are failed tests. We should address this somehow in the future.

@edan-bainglass
Copy link
Member Author

LGTM!

It's very alloying that there are failed tests. We should address this somehow in the future.

#1079

@edan-bainglass edan-bainglass merged commit a7d2e3f into aiidalab:main Jan 13, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants