-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize external resource setup notebook for code management #986
Utilize external resource setup notebook for code management #986
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 67.99% 67.99% -0.01%
==========================================
Files 113 113
Lines 6734 6740 +6
==========================================
+ Hits 4579 4583 +4
- Misses 2155 2157 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cdcfb9d
to
e294c37
Compare
Hi @superstar54. If you're interested, take a look at the last commit. I moved some stuff around to better fit our overall MVC approach. |
84a056a
to
64fbdb4
Compare
@yakutovicha can you say more regarding reasons for previously moving from external code setup to in-line widgets? |
80e2552
to
ca7a4a5
Compare
af90592
to
873eb24
Compare
e4da5f9
to
6a33aa1
Compare
ac2acce
to
bbfc57c
Compare
bbfc57c
to
09b1dec
Compare
@yakutovicha no response 😔 If okay with you, can we proceed with this PR? We can revisit in-app code setup widgets later, perhaps when the widget is in a better, lazy-loaded state. Note that we (Giovanni, Carlo, and I) have been discussion revamping the widget entirely. Let's see. |
@superstar54 can we approve this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It's very alloying that there are failed tests. We should address this somehow in the future.
|
This PR provides a top level button and a link in step 3 to the new external resource setup notebook in aiidalab-home (aiidalab/aiidalab-home#188). It also removes the code setup widget buttons from the individual code selectors in step 3 (in favor of the external notebook).