Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some random updates #1251

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Some random updates #1251

merged 5 commits into from
Aug 22, 2024

Conversation

002-sans
Copy link
Contributor

As i can saw, you should do a limit at groups or it will send an error: Cannot message this user. And it will be great is <Message>.markUnread() can so 1 ping and not 0 ping

@aiko-chan-ai
Copy link
Owner

actually you can create group dms with just you

@002-sans
Copy link
Contributor Author

actually you can create group dms with just you

<ChannelManager>.createGroupDM([client.user]) for having no bug so

@aiko-chan-ai
Copy link
Owner

image

	console.log('Ready!', client.user.tag);
	const channel = await client.channels.createGroupDM();
	console.log("Channel created", channel.id);
	channel.send('hi');

@aiko-chan-ai
Copy link
Owner

image
group created with only one account

@002-sans
Copy link
Contributor Author

I know it :/ I didn't said it's not possible bcs I do it :/ I said it can have some errors (I already try it with my alt). The recipients shouldn't be [] but [<ClientUser>.id] for having no trouble...

@002-sans
Copy link
Contributor Author

If there's no .setName in Custom Status, the presence is Custom Status (with an emoji if you put it). That's not what we want. If there's an Emoji and no Name, we just want the emoji at Custom Status.

Copy link

socket-security bot commented Aug 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected])

View full report↗︎

@aiko-chan-ai
Copy link
Owner

I know it :/ I didn't said it's not possible bcs I do it :/ I said it can have some errors (I already try it with my alt). The recipients shouldn't be [] but [<ClientUser>.id] for having no trouble...

Bc i filter friends
https://github.com/aiko-chan-ai/discord.js-selfbot-v13/pull/1251/files#diff-19338f04c86e704e9e4cb898fc9d21411ca4774ecae906a4e3179a306f55974dL130

@aiko-chan-ai
Copy link
Owner

aiko-chan-ai commented Aug 22, 2024

I think you don't need to add a line to check for a valid user

@002-sans
Copy link
Contributor Author

ah yea, maybe, just sometime i got the error that "I can dm this user" but I am friend with him (when I try to create a group with only one user) but with only me it work.

@aiko-chan-ai
Copy link
Owner

ah yea, maybe, just sometime i got the error that "I can dm this user" but I am friend with him (when I try to create a group with only one user) but with only me it work.

Because the ability to create group DMs with only one person is likely a bug in Discord, but if it hasn't been fixed, just skip the check.

@002-sans
Copy link
Contributor Author

Because the ability to create group DMs with only one person is likely a bug in Discord, but if it hasn't been fixed, just skip the check.

Yea I think, so my bad

@aiko-chan-ai
Copy link
Owner

nvm, I’m really looking forward to this PR so that I can implement a few other things

@002-sans
Copy link
Contributor Author

some news:
if recipients = [] it will create a group only with ClientUser
if recipients = ["ID1"] it will create a DM (not what we wanna do)
if recipients = ["ID1", "ID2"] it will create a group BUT

if you're not friend with someone, the filter dosn't work and will return DiscordAPIError: Cannot send messages to this user

@aiko-chan-ai
Copy link
Owner

So when recipients.length is 1, an error will be notified.

@aiko-chan-ai aiko-chan-ai merged commit 9591b4c into aiko-chan-ai:main Aug 22, 2024
2 checks passed
@aiko-chan-ai
Copy link
Owner

3:24 AM

@002-sans
Copy link
Contributor Author

3:24 AM

That's the hour for your country ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants