Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify metric names in ApiMetric & MetricsRepository #1097

Closed
MorrisNein opened this issue May 11, 2023 · 0 comments · Fixed by #1167
Closed

Unify metric names in ApiMetric & MetricsRepository #1097

MorrisNein opened this issue May 11, 2023 · 0 comments · Fixed by #1167
Assignees
Labels
api Anything related to user-facing interfaces & parameter passing good first issue Good for newcomers minor Minor changes

Comments

@MorrisNein
Copy link
Collaborator

Currently, when a user passes a metric name to FEDOT API, the ApiMetric maps the name to the function.

ApiMetric contains its own map from metric names to metric implementations that does not correspond to the inner MetricsRepository.

This leads to different metric names in API ("acc" instead of "accuracy") or inability to use some metrics by their names (such as "precision")

Therefore, ApiMetric should use MetricsRepository instead of its own map.

@MorrisNein MorrisNein added good first issue Good for newcomers minor Minor changes api Anything related to user-facing interfaces & parameter passing labels May 11, 2023
@YamLyubov YamLyubov self-assigned this Sep 7, 2023
@YamLyubov YamLyubov linked a pull request Sep 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Anything related to user-facing interfaces & parameter passing good first issue Good for newcomers minor Minor changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants