Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant metrics mapping #1167

Merged
merged 26 commits into from
Sep 14, 2023
Merged

Remove redundant metrics mapping #1167

merged 26 commits into from
Sep 14, 2023

Conversation

YamLyubov
Copy link
Collaborator

@YamLyubov YamLyubov commented Sep 7, 2023 •
edited
Loading

Removes additional mapping of metrics and ApiMetrics.
#1097

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #1167 (122bb7c) into master (7cd593e) will decrease coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 87.80%.

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
- Coverage   79.77%   79.71%   -0.06%     
==========================================
  Files         142      141       -1     
  Lines        9863     9851      -12     
==========================================
- Hits         7868     7853      -15     
- Misses       1995     1998       +3
Files Changed Coverage Δ
fedot/core/composer/metrics.py 92.05% <71.42%> (-0.70%) ⬇️
fedot/api/main.py 63.33% <77.77%> (+0.53%) ⬆️
...dot/core/optimisers/objective/metrics_objective.py 94.73% <87.50%> (-5.27%) ⬇️
fedot/api/api_utils/api_composer.py 94.84% <100.00%> (ø)
...edot/core/repository/quality_metrics_repository.py 98.21% <100.00%> (+0.53%) ⬆️

... and 3 files with indirect coverage changes

@aim-pep8-bot
Copy link

aim-pep8-bot commented Sep 8, 2023 •
edited
Loading

Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:1: F401 'typing.Callable' imported but unused

Comment last updated at 2023-09-14 09:48:08 UTC

@YamLyubov YamLyubov linked an issue Sep 8, 2023 that may be closed by this pull request
Unify metric names in ApiMetric & MetricsRepository #1097
Closed
@MorrisNein MorrisNein self-requested a review September 11, 2023 18:19
MorrisNein
MorrisNein requested changes Sep 13, 2023
View reviewed changes
fedot/api/api_utils/api_composer.py Show resolved Hide resolved
fedot/api/main.py Outdated Show resolved Hide resolved
fedot/api/main.py Outdated Show resolved Hide resolved
fedot/core/optimisers/objective/metrics_objective.py Outdated Show resolved Hide resolved
test/unit/pipelines/prediction_intervals/__init__.py Show resolved Hide resolved
@MorrisNein MorrisNein self-requested a review September 14, 2023 10:15
MorrisNein
MorrisNein approved these changes Sep 14, 2023
View reviewed changes
fedot/api/main.py
- pipeline complexity (task-independent)-> \
- time series forcasting -> \
:class:`~fedot.core.repository.quality_metrics_repository.TimeSeriesForecastingMetricsEnum`
- pipeline complexity (task-independent) -> \
:class:`~fedot.core.repository.quality_metrics_repository.ComplexityMetricsEnum`
Copy link
Collaborator

@MorrisNein MorrisNein Sep 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Посмотри, пожалуйста, в результате изменений эта докстринга актуальна?

@YamLyubov YamLyubov merged commit 17b2ecd into master Sep 14, 2023
@YamLyubov YamLyubov deleted the unify-metrics-mapping branch September 14, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisNein MorrisNein MorrisNein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify metric names in ApiMetric & MetricsRepository
4 participants
@YamLyubov @aim-pep8-bot @MorrisNein @valer1435