You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
The new 2.0 implementation has a number of places where it either takes an explicit loop parameter, or passes one to an asyncio function. The need for this was largely removed in Python 3.5.3 (because get_event_loop was changed to return the event loop of the current task when called from inside a task), and many functions (such as wait_for deprecated the parameter in 3.8 with removal for 3.10. Other functions (like open_connection) didn't deprecate it, but made it optional and documented that it is not needed when called from a coroutine. I wouldn't be surprised if they are deprecated in future.
I would suggest:
(a) eliminating passing the parameter where it is deprecated e.g. wait_for
(b) eliminating passing the parameter where it is unnecessary
(c) eliminating the loop argument to the Connection constructor and the _loop attribute. The finalizer currently uses it, but I've argued in #930 that this is a bad idea.
Let me know if a PR is likely to be looked at.
The text was updated successfully, but these errors were encountered:
The new 2.0 implementation has a number of places where it either takes an explicit
loop
parameter, or passes one to an asyncio function. The need for this was largely removed in Python 3.5.3 (becauseget_event_loop
was changed to return the event loop of the current task when called from inside a task), and many functions (such as wait_for deprecated the parameter in 3.8 with removal for 3.10. Other functions (like open_connection) didn't deprecate it, but made it optional and documented that it is not needed when called from a coroutine. I wouldn't be surprised if they are deprecated in future.I would suggest:
(a) eliminating passing the parameter where it is deprecated e.g. wait_for
(b) eliminating passing the parameter where it is unnecessary
(c) eliminating the
loop
argument to theConnection
constructor and the_loop
attribute. The finalizer currently uses it, but I've argued in #930 that this is a bad idea.Let me know if a PR is likely to be looked at.
The text was updated successfully, but these errors were encountered: