-
Notifications
You must be signed in to change notification settings - Fork 335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
- Coverage 89.19% 89.16% -0.03%
==========================================
Files 21 21
Lines 6823 6823
Branches 653 653
==========================================
- Hits 6086 6084 -2
- Misses 567 569 +2
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to address #1040 first
@abrookins L25 in setup.py needs to be changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if a fix for #1040 will be breaking in anyone's production, but we'll see. (Edit: in retrospect, if it doesn't work, it won't break anything since it just won't work.)
LGTM!!!
We'll add that back. I removed it while trying to fix #1040, but the attempt was unsuccessful. Also, we should be able to maintain compatibility either way. |
What do these changes do?
Bumps the version to 2.0.0 in prep for tagging the release.
Fixes #1031
Are there changes in behavior for the user?
An unqualified
pip install aioredis
will now install version 2.0.0. This version is not backwards compatible with earlier versions of aioredis. Instead, it aims to port the redis-py API to asyncio.Related issue number
#930
Checklist
CONTRIBUTORS.txt
<Name> <Surname>
.CHANGES/
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.