-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PyPI trusted publishing (#1116) #1154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
==========================================
+ Coverage 86.98% 87.03% +0.05%
==========================================
Files 64 64
Lines 5969 5969
==========================================
+ Hits 5192 5195 +3
+ Misses 777 774 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ac1d846
to
d55d6e2
Compare
@thehesiod: Do you want to give the new publishing action a spin? :-) |
I'd check the trusted publishing config first. It's standardized around different naming in the org so your workflow will probably not match.. |
@jakob-keller The job name and the environment name have to match the following values: You'll need a follow-up PR to make it work. |
based on @webknjaz 's reply sounds like we need a follow-up? |
Sure, will do in a few hours. Sorry for jumping the gun on this one and thanks @webknjaz for your guidance! |
Description of Change
Switch to PyPI trusted publishing
Assumptions
Trusted publisher is configured for this project.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions