Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyPI trusted publishing (#1116) #1154

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Switch to PyPI trusted publishing

Assumptions

Trusted publisher is configured for this project.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Switch CI/CD to PyPI trusted publishing #1116
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Aug 19, 2024
@jakob-keller jakob-keller self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (1fdfd69) to head (d55d6e2).
Report is 82 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   86.98%   87.03%   +0.05%     
==========================================
  Files          64       64              
  Lines        5969     5969              
==========================================
+ Hits         5192     5195       +3     
+ Misses        777      774       -3     
Flag Coverage Δ
unittests 87.03% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit a8e64a4 into aio-libs:master Aug 20, 2024
11 checks passed
@jakob-keller jakob-keller deleted the trusted-publishing branch August 20, 2024 00:56
@jakob-keller
Copy link
Collaborator Author

@thehesiod: Do you want to give the new publishing action a spin? :-)

@webknjaz
Copy link
Member

I'd check the trusted publishing config first. It's standardized around different naming in the org so your workflow will probably not match..

@webknjaz
Copy link
Member

@jakob-keller The job name and the environment name have to match the following values:
Screenshot_2024-08-20-06-25-51-36_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

You'll need a follow-up PR to make it work.

@thehesiod
Copy link
Collaborator

@thehesiod: Do you want to give the new publishing action a spin? :-)

based on @webknjaz 's reply sounds like we need a follow-up?

@jakob-keller
Copy link
Collaborator Author

Sure, will do in a few hours. Sorry for jumping the gun on this one and thanks @webknjaz for your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch CI/CD to PyPI trusted publishing
3 participants