Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump botocore dependency specification #1265

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Jan 16, 2025

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains several changes that require adjustments to the aiobotocore codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Support up-to-date botocore #1263
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Jan 16, 2025
@jakob-keller jakob-keller self-assigned this Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.55%. Comparing base (abfaae4) to head (04d7296).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   88.17%   87.55%   -0.63%     
==========================================
  Files          67       67              
  Lines        5904     5905       +1     
==========================================
- Hits         5206     5170      -36     
- Misses        698      735      +37     
Flag Coverage Δ
unittests 87.55% <100.00%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review January 17, 2025 00:15
@thehesiod
Copy link
Collaborator

how's uv looking btw?

@jakob-keller
Copy link
Collaborator Author

Thanks for the review!

how's uv looking btw?

Just as it should! I‘ve been using it with other projects for a while now and am really happy with its performance and workflows. Let me know, if you have any questions.

@jakob-keller jakob-keller added this pull request to the merge queue Jan 17, 2025
Merged via the queue into aio-libs:master with commit ed34a55 Jan 17, 2025
11 checks passed
@jakob-keller jakob-keller deleted the bump-botocore branch January 17, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support up-to-date botocore
2 participants