Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix for streaming body responses - load body to BytesIO #18

Closed
wants to merge 1 commit into from
Closed

Temporary fix for streaming body responses - load body to BytesIO #18

wants to merge 1 commit into from

Conversation

oselivanov
Copy link

…ect.

@oselivanov
Copy link
Author

Hm, looks like version in master already fixed. Closing as invalid for now.

@oselivanov oselivanov closed this Dec 30, 2015
@oselivanov
Copy link
Author

I've ran wrong test, actually it's still broken, so my fix is valid.

@oselivanov oselivanov mentioned this pull request Dec 30, 2015
Closed
@oselivanov oselivanov reopened this Dec 30, 2015
@oselivanov
Copy link
Author

This quickfix breaks API BTW.

body = await obj['Body'].read()

will become

body = obj['Body'].read()

I'll fix it today if I have a minute.

@oselivanov
Copy link
Author

Done. I've amended commit.

@cbrichford cbrichford mentioned this pull request Jan 19, 2016
Merged
@cbrichford
Copy link

I believe #19 ( which was just merged ) fixes this issue.

@jettify jettify closed this Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oselivanov @cbrichford @jettify