Poetry packaging

[dazza-codes]

Fix #833 although it does not use a lambci docker container in the travis-CI matrix.

This PR is a response to difficulty on a couple of other PRs when I can't grapple with pipenv for my dev-env. There might be bits-n-pieces of this PR that are welcome and other bits that are not. I'm open to discussion, testing and compromises. I'm not having much success with pipenv. Even if this PR is not adopted/merged, I will find it useful to work with this branch and rebase on master and manage a parallel set of poetry-deps as needed.

This is an attempt to use poetry packaging for the project and it might be a contentious PR/issue, depending on dev-team preferences for dev-env setups. In using poetry for the past year or so, this PR represents some patterns that are working consistently for me. Hopefully the added files are mostly self-explanatory, please ask any questions to clarify things and take it for a spin on your local to see how it works out.

TODO

• update CI/CD to use poetry
• contributions require using python 3.8 now (?)
• tests might assume there is a default profile available to get credentials (?), lots of failures without it

[thehesiod]

hmm perhaps aioboto should switch to pyproject.toml as well. Sorry really behind in the forward looking PRs, will try to look soon just been super busy since move, or maybe another aioboto admin can chime in =)

[lgtm-com]

This pull request fixes 5 alerts when merging 32bd40b into 2a7c7f5 - view on LGTM.com

fixed alerts:

• 3 for `__eq__` not overridden when adding attributes
• 1 for Missing call to `__init__` during object initialization
• 1 for Module is imported with 'import' and 'import from'

[lgtm-com]

This pull request fixes 5 alerts when merging 12d3d09 into 2a7c7f5 - view on LGTM.com

fixed alerts:

• 3 for `__eq__` not overridden when adding attributes
• 1 for Missing call to `__init__` during object initialization
• 1 for Module is imported with 'import' and 'import from'

[lgtm-com]

This pull request fixes 5 alerts when merging b8e8436 into 2a7c7f5 - view on LGTM.com

fixed alerts:

• 3 for `__eq__` not overridden when adding attributes
• 1 for Missing call to `__init__` during object initialization
• 1 for Module is imported with 'import' and 'import from'

[lgtm-com]

This pull request fixes 6 alerts when merging b1dc068 into ef96004 - view on LGTM.com

fixed alerts:

• 3 for `__eq__` not overridden when adding attributes
• 2 for Module is imported with 'import' and 'import from'
• 1 for Missing call to `__init__` during object initialization

[thehesiod]

@dazza-codes given that botocore has swapped to https://github.com/boto/botocore/blob/develop/pyproject.toml seems like this now makes even more sense, thoughts?

[lafrenierejm]

@dazza-codes I rebased on this PR to fix unit tests and linting in my fork: lafrenierejm/aiobotocore@poetry-packaging. Would you consider resetting this PR to my updated branch? Or would you prefer that I open a separate PR for review?

[thehesiod]

could you work with #975 so we get a PR that includes both aspects? thanks!

[jakob-keller]

@thehesiod: Would you agree that this PR is stale and may be closed at this point?

[thehesiod]

@thehesiod: Would you agree that this PR is stale and may be closed at this point?

yep agreed, a ton has changed. We should have an issue to discuss this about where we want to head, so many tools

[jakob-keller]

yep agreed, a ton has changed. We should have an issue to discuss this about where we want to head, so many tools

Closing it for now. Anyone interested in modernizing dependency management and packaging tooling, open an issue or start a discussion.