Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use function name when building the key in decorators #416

Closed
argaen opened this issue Sep 11, 2018 · 0 comments
Closed

Use function name when building the key in decorators #416

argaen opened this issue Sep 11, 2018 · 0 comments
Labels

Comments

@argaen
Copy link
Member

argaen commented Sep 11, 2018

With actual behavior there are chances of having unwanted behavior of one function overriding the result of another

#400 shows how to fix this. Next steps:

  • Ensure this is the behavior for all decorators
  • Fix tests

PS: note this only affects when a key_builder function is passed, default behavior is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant