Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decorators.py #400

Closed
wants to merge 1 commit into from
Closed

Update decorators.py #400

wants to merge 1 commit into from

Conversation

AFriemann
Copy link

key_builder now receives wrapped function as first argument

@AFriemann
Copy link
Author

regarding #399

@AFriemann
Copy link
Author

I'll update this later with fixed tests and all

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #400 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #400      +/-   ##
========================================
+ Coverage   99.77%   100%   +0.22%     
========================================
  Files           9      9              
  Lines         871    858      -13     
  Branches       95     91       -4     
========================================
- Hits          869    858      -11     
+ Misses          2      0       -2
Impacted Files Coverage Δ
aiocache/decorators.py 100% <100%> (ø) ⬆️
aiocache/backends/redis.py 100% <0%> (ø) ⬆️
aiocache/backends/memcached.py 100% <0%> (ø) ⬆️
aiocache/factory.py 100% <0%> (ø) ⬆️
aiocache/lock.py 100% <0%> (ø) ⬆️
aiocache/backends/memory.py 100% <0%> (ø) ⬆️
aiocache/base.py 100% <0%> (ø) ⬆️
aiocache/serializers.py 100% <0%> (+3.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc6814...2dea460. Read the comment docs.

@stfsy
Copy link

stfsy commented Nov 5, 2018

@AFriemann any plans on updating tests and getting this merged by.. anyone?

@AFriemann
Copy link
Author

AFriemann commented Nov 6, 2018

@stfsy as far as I know this should be solved

#417

I did rework my solution at some point, but the whole test suite is a bit bonkers. Since I'm not using this anymore I honestly just dropped it.

@argaen
Copy link
Member

argaen commented Nov 6, 2018

Indeed, @stfsy this behavior is in master. Can you give it a try. I can do a minor release if needed :)

PS: Closing the PR

@argaen argaen closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants