Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load redis asyncio.Lock #397

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

jsoucheiron
Copy link
Contributor

Lazy load asyncio.Lock on redis backend. This fixes an issue with multiprocess apps like tornado that might fork after import time.

Copy link
Member

@argaen argaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the changelog and version changes as they are automatically generated.

I've rerun the docs step coz no idea why it has failed

CHANGELOG.md Outdated
## 0.9.1 (2018-04-25)

* Lazy load asyncio.Lock on redis backend. This fixes an issue with multiprocess
apps like tornado that might fork after import time. - Jordi Soucheiron
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add this, the changelog is generated automatically whenever there is a new release

@@ -1 +1 @@
__version__ = '0.9.0'
__version__ = '0.9.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #397 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #397   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         854    858    +4     
  Branches       90     91    +1     
=====================================
+ Hits          854    858    +4
Impacted Files Coverage Δ
aiocache/backends/redis.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf50df...cea07f0. Read the comment docs.

@jsoucheiron
Copy link
Contributor Author

Reverted

@argaen argaen merged commit f97f90f into aio-libs:master Apr 26, 2018
@argaen
Copy link
Member

argaen commented Apr 26, 2018

Thanks! will do a 0.9.1 release this afternoon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants