-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load redis asyncio.Lock #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just remove the changelog and version changes as they are automatically generated.
I've rerun the docs step coz no idea why it has failed
CHANGELOG.md
Outdated
## 0.9.1 (2018-04-25) | ||
|
||
* Lazy load asyncio.Lock on redis backend. This fixes an issue with multiprocess | ||
apps like tornado that might fork after import time. - Jordi Soucheiron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add this, the changelog is generated automatically whenever there is a new release
aiocache/_version.py
Outdated
@@ -1 +1 @@ | |||
__version__ = '0.9.0' | |||
__version__ = '0.9.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 854 858 +4
Branches 90 91 +1
=====================================
+ Hits 854 858 +4
Continue to review full report at Codecov.
|
Reverted |
Thanks! will do a 0.9.1 release this afternoon :) |
Lazy load asyncio.Lock on redis backend. This fixes an issue with multiprocess apps like tornado that might fork after import time.