-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typehints in lock.py #434
Conversation
thanks @aviv-ebates! can you fix the syntax errors? no need to import the |
hey @argaen , I've fixed the |
Oh wow, seems tests started failed since yesterday, probably a rogue dependency for testing. Will check and then rebase this branch with master then to see if build passes |
- The constructors take an instance of type `BaseCache`, not `Type[]` - Mypy doesn't consider `True` to be a type.
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
===========================================
- Coverage 99.77% 36.12% -63.65%
===========================================
Files 10 10
Lines 894 894
Branches 96 96
===========================================
- Hits 892 323 -569
- Misses 2 571 +569
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
===========================================
- Coverage 99.77% 36.12% -63.65%
===========================================
Files 10 10
Lines 894 894
Branches 96 96
===========================================
- Hits 892 323 -569
- Misses 2 571 +569
Continue to review full report at Codecov.
|
thanks! |
thanks for the contribution! :) |
BaseCache
, notType[]
True
to be a type.