Fix host detection raising unclear exception

aio-libs · Sep 17, 2015 · 5b0065c · 5b0065c
1 parent fcfef58
commit 5b0065c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/aiohttp/client_reqrep.py b/aiohttp/client_reqrep.py
@@ -112,6 +112,9 @@ def update_host(self, url):
 
         # get host/port
         host = url_parsed.hostname
+        if not host:
+            raise ValueError('Host could not be detected.')
+
         try:
             port = url_parsed.port
         except ValueError:

diff --git a/tests/test_client_request.py b/tests/test_client_request.py
@@ -96,6 +96,11 @@ def test_host_port_err(self):
             ValueError, ClientRequest, 'get', 'http://python.org:123e/',
             loop=self.loop)
 
+    def test_hostname_err(self):
+        self.assertRaises(
+            ValueError, ClientRequest, 'get', 'http://:8080/',
+            loop=self.loop)
+
     def test_host_header(self):
         req = ClientRequest('get', 'http://python.org/', loop=self.loop)
         self.assertEqual(req.headers['HOST'], 'python.org')