Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly expose TooManyRedirects #3819

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

Harmon758
Copy link
Member

What do these changes do?

Expose TooMayRedirects publicly

Are there changes in behavior for the user?

aiohttp.TooManyRedirects is now exposed as documented.

Related issue number

Fixes #3818

Checklist

  • I think the code is well written
  • [N/A] Unit tests for the changes exist
  • Documentation reflects the changes
  • [N/A] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@Harmon758 Harmon758 requested a review from asvetlov as a code owner June 7, 2019 11:49
@Harmon758 Harmon758 force-pushed the expose-toomanyredirects branch from 30a6d35 to 58495c7 Compare June 7, 2019 11:52
@Harmon758 Harmon758 force-pushed the expose-toomanyredirects branch from 58495c7 to 4a07f9f Compare June 7, 2019 11:59
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-io
Copy link

Codecov Report

Merging #3819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3819   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files          43       43           
  Lines        8589     8589           
  Branches     1375     1375           
=======================================
  Hits         8413     8413           
  Misses         74       74           
  Partials      102      102
Impacted Files Coverage Δ
aiohttp/__init__.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81cc715...4a07f9f. Read the comment docs.

@asvetlov asvetlov merged commit f22ebd7 into aio-libs:master Jun 7, 2019
@Harmon758 Harmon758 deleted the expose-toomanyredirects branch June 7, 2019 13:34
asvetlov pushed a commit that referenced this pull request Jun 7, 2019
(cherry picked from commit f22ebd7)

Co-authored-by: Harmon <[email protected]>
asvetlov added a commit that referenced this pull request Jun 7, 2019
(cherry picked from commit f22ebd7)

Co-authored-by: Harmon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TooManyRedirects is not properly exposed publicly
3 participants