-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URL params to ClientSession.ws_connect #5869
Conversation
Co-authored-by: Anes Abismail <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply b8f4d70 on top of patchback/backports/3.8/b8f4d70e63f54cf5f32961f2e2bc2690b52a3c90/pr-5869 Backporting merged PR #5869 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
* Fix URL params were unavailable in ws_connect (#5868) * Update CHANGES/5868.bugfix Co-authored-by: Anes Abismail <[email protected]> * Update 5868.bugfix Co-authored-by: Anes Abismail <[email protected]> Co-authored-by: Andrew Svetlov <[email protected]>
Backported by 708dd98 |
Thank you Andrew ! |
What do these changes do?
These changes add the
params
argument toClientSession.ws_connect
, so WebSocket requests can contain a query component.Are there changes in behavior for the user?
Yes, this adds an extra keyword argument on
ClientSession.ws_connect
. The change is backward compatible.Related issue number
#5868
Checklist
CONTRIBUTORS.txt
CHANGES
folder