Fix pip reinstallation on windows due to constraints #6756
Conversation
|
@Dreamsorcerer PTAL |
Codecov Report
@@ Coverage Diff @@
## master #6756 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 104 104
Lines 30627 30627
Branches 3076 3076
=======================================
Hits 28620 28620
Misses 1838 1838
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Weird. Fine by me. |
Dreamsorcerer
added
the
bot:chronographer:skip
|
Hmm, Timeline protection seems to have broken. I guess it's a remote call, so maybe the server is down? |
@webknjaz should know, I suppose. |
|
Urgh... Must be the same problem as with Patchback.. sanitizers/patchback-github-app#27 |
|
Should be fixed now. |
webknjaz
added
bot:chronographer:skip
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #6759 🤖 @patchback |
(cherry picked from commit 72d3d4b)
(cherry picked from commit 72d3d4b) Co-authored-by: Slava <[email protected]>
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6911 🤖 @patchback |
(cherry picked from commit 72d3d4b)
…ue to constraints (#6911) **This is a backport of PR #6756 as merged into master (72d3d4b).** ## What do these changes do? Fix for constantly failing CI on windows agents. ## Description We have pinned pip version in constraints.txt file: https://github.com/aio-libs/aiohttp/blob/08ca779e9abdb6d558cdd1647fdca17cfe979711/requirements/constraints.txt#L260 So when you call `pip install ... -c constraints.txt` it will downgrade/upgrade pip depending on the currently installed version. This works fine on all platforms except windows, which forces you to explicitly use `python -m pip install ...` when dealing with the pip package itself. Since `python -m pip install ...` command is a completely legit replacement for `pip install ...` ([examples ](https://pip.pypa.io/en/latest/getting-started/)from the pip wiki), I decided to update `Makefile` with it. Co-authored-by: Slava <[email protected]>
What do these changes do?
Fix for constantly failing CI on windows agents.
Description
We have pinned pip version in constraints.txt file:
aiohttp/requirements/constraints.txt
Line 260 in 08ca779
So when you call
pip install ... -c constraints.txtit will downgrade/upgrade pip depending on the currently installed version. This works fine on all platforms except windows, which forces you to explicitly usepython -m pip install ...when dealing with the pip package itself.Since
python -m pip install ...command is a completely legit replacement forpip install ...(examples from the pip wiki), I decided to updateMakefilewith it.