[PR #7240/315ae903 backport][3.9] Reduce access log overhead when logging is disabled #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
<!-- Thank you for your contribution! -->
## What do these changes do?
If the logger was disabled the log message would be formatted and thrown
away. Avoid formatting the log message when logging is not enabled at
info level.
In testing this represented up to 12% of the run time of serving a
static file.
## Are there changes in behavior for the user?
No
## Related issue number
<!-- Are there any issues opened that will be resolved by merging this
change? -->
## Checklist
- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
* The format is <Name> <Surname>.
* Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES` folder
* name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
* ensure type is one of the following:
* `.feature`: Signifying a new feature.
* `.bugfix`: Signifying a bug fix.
* `.doc`: Signifying a documentation improvement.
* `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."
---------
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 315ae90)
5 tasks
Codecov Report
@@ Coverage Diff @@
## 3.9 #7254 +/- ##
==========================================
- Coverage 97.32% 97.31% -0.01%
==========================================
Files 108 108
Lines 31587 31596 +9
Branches 4012 4013 +1
==========================================
+ Hits 30741 30748 +7
- Misses 640 641 +1
- Partials 206 207 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dreamsorcerer
deleted the
patchback/backports/3.9/315ae9037438351b48a712734173020374e5ff33/pr-7240
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7240 as merged into master (315ae90).
What do these changes do?
If the logger was disabled the log message would be formatted and thrown away. Avoid formatting the log message when logging is not enabled at info level.
In testing this represented up to 12% of the run time of serving a static file.
Are there changes in behavior for the user?
No
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.