-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CancelledError stopping other cleanup contexts completing #8908
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #8908 +/- ##
==========================================
+ Coverage 98.24% 98.25% +0.01%
==========================================
Files 107 107
Lines 34130 34126 -4
Branches 4050 4049 -1
==========================================
Hits 33531 33531
+ Misses 423 421 -2
+ Partials 176 174 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 032fb57 on top of patchback/backports/3.10/032fb571f2c73605d855d4f17026b303c7441823/pr-8908 Backporting merged PR #8908 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 032fb57 on top of patchback/backports/3.11/032fb571f2c73605d855d4f17026b303c7441823/pr-8908 Backporting merged PR #8908 into master
🤖 @patchback |
(cherry picked from commit 032fb57)
(cherry picked from commit 032fb57)
I wonder if we should even just catch BaseException here...?
Then a KeyboardInterrupt or similar could cancel each context individually.
Fixes #5672.