Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling update_cookies when there are no cookies #9470

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Avoid calling update_cookies when there are no cookies #9470

merged 2 commits into from
Oct 11, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 11, 2024

What do these changes do?

Calling update_cookies is ~4% of the client lifecycle time and we call it even with an empty dict of cookies

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Oct 11, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 11, 2024
bdraco added 2 commits October 11, 2024 13:11
@bdraco
Avoid calling update_cookies when there are no cookies
e57d2de 
Calling update_cookies is ~4% of the client lifecycle time
and we call it even with an empty dict of cookies
@bdraco
changelog
02011e0
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (8a4707e) to head (02011e0).
Report is 627 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9470   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         105      105           
  Lines       35091    35092    +1     
  Branches     4178     4179    +1     
=======================================
+ Hits        34597    34599    +2     
  Misses        329      329           
+ Partials      165      164    -1
Flag Coverage Δ
CI-GHA 98.47% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.14% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.53% <ø> (ø)
OS-macOS 97.83% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.71% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.63% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.70% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.78% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.19% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.18% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.60% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.53% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.16% <100.00%> (+<0.01%) ⬆️
VM-macos 97.83% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.14% <100.00%> (+<0.01%) ⬆️
VM-windows 96.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 11, 2024 18:25
@bdraco bdraco enabled auto-merge (squash) October 11, 2024 18:25
@bdraco bdraco merged commit 5bded30 into master Oct 11, 2024
36 of 37 checks passed
@bdraco bdraco deleted the cookies branch October 11, 2024 18:30
@patchback Patchback
Copy link
Contributor

patchback bot commented Oct 11, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/5bded303dd7c5ad22daaa89ca352c2025e9c75dc/pr-9470

Backported as #9471

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 11, 2024
@bdraco @patchback
Avoid calling update_cookies when there are no cookies (#9470)
f77e0df 
(cherry picked from commit 5bded30)
@patchback patchback bot mentioned this pull request Oct 11, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Oct 11, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/5bded303dd7c5ad22daaa89ca352c2025e9c75dc/pr-9470

Backported as #9472

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 11, 2024
@bdraco @patchback
Avoid calling update_cookies when there are no cookies (#9470)
e650979 
(cherry picked from commit 5bded30)
@patchback patchback bot mentioned this pull request Oct 11, 2024
Merged
bdraco added a commit that referenced this pull request Oct 11, 2024
@patchback @bdraco
[PR #9470/5bded303 backport][3.10] Avoid calling update_cookies when …
bbf7da3 
…there are no cookies (#9471)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Oct 11, 2024
@patchback @bdraco
[PR #9470/5bded303 backport][3.11] Avoid calling update_cookies when …
935b335 
…there are no cookies (#9472)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco