Fix refactoring error from moving WebSocket mask #9558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
CodSpeed Performance ReportMerging #9558 will improve performances by ×2.9Comparing Summary
Benchmarks breakdown
|
bdraco
added
the
backport-3.11
bdraco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9558 +/- ##
==========================================
+ Coverage 98.58% 98.60% +0.01%
==========================================
Files 113 113
Lines 35265 35266 +1
Branches 4188 4188
==========================================
+ Hits 34765 34773 +8
+ Misses 338 331 -7
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Oct 28, 2024
Merged
and adjust the test to confirm the import works
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9563 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 0a70662)
bdraco
added a commit
that referenced
this pull request
Oct 28, 2024
…WebSocket mask (#9563) Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9543 missed changing the import when the code was relocated. Fix the import and adjust the test to confirm the import works. This only affected the writer since the reader now
cimports the mask code.Performance tests did not catch it because the benchmarks do not use masking. A new benchmark will be added in #9559