Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of _serialize_headers #9603

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 1, 2024

Improve performance of _serialize_headers by ~23%

Copy link

codspeed-hq bot commented Nov 1, 2024

CodSpeed Performance Report

Merging #9603 will improve performances by 23.62%

Comparing _serialize_headers (76c7a43) with master (898aa28)

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark master _serialize_headers Change
test_serialize_headers 1.6 ms 1.3 ms +23.62%

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (898aa28) to head (76c7a43).
Report is 594 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9603   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files         114      114           
  Lines       35370    35370           
  Branches     4195     4195           
=======================================
  Hits        34887    34887           
  Misses        323      323           
  Partials      160      160           
Flag Coverage Δ
CI-GHA 98.51% <ø> (ø)
OS-Linux 98.19% <ø> (ø)
OS-Windows 96.09% <ø> (ø)
OS-macOS 97.40% <ø> (ø)
Py-3.10.11 97.26% <ø> (ø)
Py-3.10.15 97.67% <ø> (ø)
Py-3.11.10 97.73% <ø> (-0.01%) ⬇️
Py-3.11.9 97.33% <ø> (-0.02%) ⬇️
Py-3.12.7 98.22% <ø> (ø)
Py-3.13.0 98.21% <ø> (ø)
Py-3.9.13 97.17% <ø> (-0.01%) ⬇️
Py-3.9.20 97.58% <ø> (ø)
Py-pypy7.3.16 97.19% <ø> (ø)
VM-macos 97.40% <ø> (ø)
VM-ubuntu 98.19% <ø> (ø)
VM-windows 96.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 1, 2024
@bdraco bdraco force-pushed the _serialize_headers branch from 49c92d0 to 6a8a5dd Compare November 1, 2024 18:05
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 1, 2024
@bdraco bdraco marked this pull request as ready for review November 1, 2024 18:42
bdraco added a commit to aio-libs/yarl that referenced this pull request Nov 1, 2024
@bdraco bdraco force-pushed the _serialize_headers branch from 80d3ea1 to 76c7a43 Compare November 2, 2024 15:24
@bdraco bdraco merged commit 4108ca5 into master Nov 2, 2024
40 of 41 checks passed
@bdraco bdraco deleted the _serialize_headers branch November 2, 2024 15:45
Copy link
Contributor

patchback bot commented Nov 2, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/4108ca51c10df4bf58cb5faf13cf81816a29a15d/pr-9603

Backported as #9626

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 2, 2024
Copy link
Contributor

patchback bot commented Nov 2, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/4108ca51c10df4bf58cb5faf13cf81816a29a15d/pr-9603

Backported as #9627

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 2, 2024
bdraco added a commit that referenced this pull request Nov 2, 2024
bdraco added a commit that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant