-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid calling the drain helper in WebSocketWriter
if the protocol is not paused
#9796
Conversation
CodSpeed Performance ReportMerging #9796 will improve performances by 22.38%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9796 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 118 118
Lines 35997 35998 +1
Branches 4278 4279 +1
=======================================
+ Hits 35526 35527 +1
Misses 316 316
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WebSocketWriter
if the protocol is not paused
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9797 🤖 @patchback |
…`WebSocketWriter` if the protocol is not paused (#9797) Co-authored-by: J. Nick Koston <[email protected]>
same as #9796 but for the http writer
We already know its connected or it would have raised for
is_closing
so we can guard calling the coro with a check to see if its paused