Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13, remove 3.8 #1061

Merged
merged 7 commits into from
Oct 26, 2024
Merged

Add Python 3.13, remove 3.8 #1061

merged 7 commits into from
Oct 26, 2024

Conversation

ods
Copy link
Collaborator

@ods ods commented Oct 26, 2024

Changes

Fixes #

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

aiokafka/record/_protocols.py Dismissed Show dismissed Hide dismissed
aiokafka/record/_protocols.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 94.21053% with 11 lines in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (608ab24) to head (191354f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tests/conftest.py 40.00% 2 Missing and 1 partial ⚠️
aiokafka/record/_protocols.py 33.33% 0 Missing and 2 partials ⚠️
aiokafka/cluster.py 66.66% 1 Missing ⚠️
aiokafka/consumer/group_coordinator.py 88.88% 1 Missing ⚠️
aiokafka/metrics/stats/histogram.py 0.00% 1 Missing ⚠️
aiokafka/protocol/produce.py 0.00% 1 Missing ⚠️
aiokafka/record/_crc32c.py 50.00% 0 Missing and 1 partial ⚠️
tests/_testutil.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
+ Coverage   95.03%   95.11%   +0.07%     
==========================================
  Files         114      114              
  Lines       16985    16982       -3     
  Branches     1736     1579     -157     
==========================================
+ Hits        16142    16152      +10     
+ Misses        491      482       -9     
+ Partials      352      348       -4     
Flag Coverage Δ
cext 92.08% <92.10%> (+0.08%) ⬆️
integration 94.80% <94.21%> (+0.06%) ⬆️
purepy 94.61% <93.68%> (+0.06%) ⬆️
unit 53.04% <81.05%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods merged commit e7c9033 into aio-libs:master Oct 26, 2024
29 of 31 checks passed
@ods ods deleted the python313 branch October 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant