Add SASL_PLAINTEXT and SASL_SSL to valid values in security protocol … #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelrubin
force-pushed
the
security-protocol-doc
branch
from
d58cee4 to
15fb3fc
Compare
pawelrubin
force-pushed
the
security-protocol-doc
branch
from
15fb3fc to
fb8dfad
Compare
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 97.99% 97.89% -0.10%
==========================================
Files 31 31
Lines 5279 5279
==========================================
- Hits 5173 5168 -5
- Misses 106 111 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Valid values for the
security_protocolattribute in fact contain also"SASL_PLAINTEXT"and"SASL_SSL".Checklist
I think the code is well writtenUnit tests for the changes existCHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.