fix connection timeouts in pool #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,6 +125,10 @@ def acquire(self): | |||
| conn = self._free.popleft() | |||
| assert not conn.closed, conn | |||
| assert conn not in self._used, (conn, self._used) | |||
| # drop if connection timedout | |||
There was a problem hiding this comment.
Would you move the patch into _fill_free_pool() method?
It makes code more clear from my perspective.
Just iterate over _free list and drop all timed-out connections.
|
Done. |
| # iterate over free connections and remove timeouted ones | ||
| free_size = len(self._free) | ||
| n = 0 | ||
| while n < free_size: |
There was a problem hiding this comment.
Hmm. Still not perfect: you are removing connection from deque and pushing it back if it is not closed (which is most likely happens).
There was a problem hiding this comment.
What do you think about instead pop/appendleft use rotate? This method does not perform unnecessary removals and just relink underlying linked list:
while n < free_size:
conn = self._free[-1]
if conn._reader.at_eof():
self._free.pop()
conn.close()
else:
self._free.rotate()
n += 1
jettify
added a commit
that referenced
this pull request
Sep 6, 2015
fix connection timeouts in pool
This was referenced Sep 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #25 and #16
@asvetlov please review.