Docker test fixtures #275
Merged
Docker test fixtures #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 9 9
Lines 1157 1157
Branches 172 172
=======================================
Hits 1075 1075
Misses 53 53
Partials 29 29Continue to review full report at Codecov.
|
Nothing4You
added a commit
that referenced
this pull request
Jan 30, 2022
this was introduced in #275 for running the database in a container but is no longer needed
Nothing4You
added a commit
that referenced
this pull request
Jan 30, 2022
this was introduced in #275 for running the database in a container but is no longer needed
Merged
Nothing4You
added a commit
that referenced
this pull request
Jan 30, 2022
this was introduced in #275 for running the database in a container but is no longer needed
Nothing4You
added a commit
that referenced
this pull request
Jan 30, 2022
this was introduced in #275 for running the database in a container but is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I noticed in a few places, MYSQL_PORT env variable was being assigned to a variable, but never actually used when the connection was made. Fixed that.
Added a pytest fixture to run MySQL in a container. It also configures MySQL to use TLS (which is optional) so it can be used for both SSL and non SSL tests.