Fix: #454 #460
Fix: #454 #460
Conversation
|
@asvetlov can you look to this? We have python3.8 app which fails because of this issue. |
|
Guys, we are stuck on this as well. All I can do is post this humble bump with a kind request to expedite a release with this fix. Thanks in advance. |
|
@asvetlov Can we have it merged and get a new version released? Python 3.8 is out for some time now, it's a real shame that aiomysql is lagging far behind... |
|
How is this not fixed yet... |
|
Hey guys! |
|
Can someone else look at this please? @webknjaz @terrycain @jettify |
aiomysql/connection.py
Outdated
| @@ -596,7 +600,7 @@ def write_packet(self, payload): | |||
| async def _read_bytes(self, num_bytes): | |||
| try: | |||
| data = await self._reader.readexactly(num_bytes) | |||
| except asyncio.streams.IncompleteReadError as e: | |||
| except IncompleteReadError as e: | |||
There was a problem hiding this comment.
From the docs, it looks like it should be
| except IncompleteReadError as e: | |
| except asyncio.IncompleteReadError as e: |
and no imports needed.
Refs:
|
Merged, somebody needs to fix the CI tho |
|
@webknjaz one last thing, could you publish new version with these changes to pypi.org? Thanks. |
|
Only when someone fixes the CI (ref #466) |
What do these changes do?
Compatible with Python3.8's IncompleteReadError
Are there changes in behavior for the user?
Related issue number
#454
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.