add support to pymysql 1.0.2

[ghostebony]

No description provided.

[Nothing4You]

hi,

thanks for the PR.

could you please reduce this to just porting PyMySQL/PyMySQL#923?
that will still be compatible with PyMySQL <1.0.0 (although I do intend to raise this before aiomysql 1.0.0 will be released)
for pack_int24 and lenenc_int I think it makes more sense to vendor these (e.g. in #554) instead of accessing non-public API of PyMySQL.

[ghostebony]

hi,

thanks for the PR.

could you please reduce this to just porting PyMySQL/PyMySQL#923? that will still be compatible with PyMySQL <1.0.0 (although I do intend to raise this before aiomysql 1.0.0 will be released) for pack_int24 and lenenc_int I think it makes more sense to vendor these (e.g. in #554) instead of accessing non-public API of PyMySQL.

something like that?

[Nothing4You]

thank you, this is what I was thinking of.

in tests/test_basic.py there's another reference to pymysql.util, with that updated the tests should run properly.

when CI and linter are green this should be good to merge.

[codecov]

Codecov Report

Merging #643 (6df06f3) into master (624de5f) will decrease coverage by 0.40%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   86.50%   86.10%   -0.41%     
==========================================
  Files          12       12              
  Lines        2082     2094      +12     
  Branches      341      346       +5     
==========================================
+ Hits         1801     1803       +2     
- Misses        216      224       +8     
- Partials       65       67       +2     

Flag	Coverage Δ
ubuntu-latest_3.10_mariadb-10.2	82.66% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.10_mariadb-10.3	82.66% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.10_mariadb-10.4	82.66% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.10_mariadb-10.5	82.66% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.10_mariadb-10.6	82.66% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.10_mariadb-10.7	82.66% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.10_mysql-5.7	83.52% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.10_mysql-8.0	85.38% <50.00%> (-0.40%)	⬇️
ubuntu-latest_3.7_mariadb-10.2	82.20% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.7_mariadb-10.3	82.20% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.7_mariadb-10.4	82.20% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.7_mariadb-10.5	82.20% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.7_mariadb-10.6	82.20% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.7_mariadb-10.7	82.20% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.7_mysql-5.7	83.08% <50.00%> (-0.40%)	⬇️
ubuntu-latest_3.7_mysql-8.0	84.99% <50.00%> (-0.41%)	⬇️
ubuntu-latest_3.8_mariadb-10.2	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.8_mariadb-10.3	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.8_mariadb-10.4	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.8_mariadb-10.5	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.8_mariadb-10.6	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.8_mariadb-10.7	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.8_mysql-5.7	83.47% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.8_mysql-8.0	85.29% <50.00%> (-0.40%)	⬇️
ubuntu-latest_3.9_mariadb-10.2	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.9_mariadb-10.3	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.9_mariadb-10.4	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.9_mariadb-10.5	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.9_mariadb-10.6	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.9_mariadb-10.7	82.61% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.9_mysql-5.7	83.47% <50.00%> (-0.39%)	⬇️
ubuntu-latest_3.9_mysql-8.0	85.29% <50.00%> (-0.40%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiomysql/utils.py	80.90% <33.33%> (-7.52%)	⬇️
aiomysql/connection.py	84.55% <100.00%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624de5f...6df06f3. Read the comment docs.

[Nothing4You]

thanks!