-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unix socket tests #686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
- Coverage 85.68% 83.76% -1.92%
==========================================
Files 12 12
Lines 2088 2088
Branches 336 336
==========================================
- Hits 1789 1749 -40
- Misses 229 271 +42
+ Partials 70 68 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
82a3555
to
bc9149f
Compare
bc9149f
to
1dbd5e9
Compare
5f83273
to
a2d4434
Compare
47dbef8
to
1f45f99
Compare
configure custom socket path for mysql container, working around implicitly created volume folders being owned by root we should probably just not use service containers for this to avoid having to do this patching
1f45f99
to
549dd46
Compare
somehow codecov broke... |
replaced by #696 |
What do these changes do?
Run the entire test suite against unix sockets as well as over TCP.
This effectively runs every test twice against every DB version, once over unix socket, once over TCP.
This also implements passing arbitrary connection info to the test suite, allowing to run tests against multiple databases in the same test run.
It can later be expanded to run more databases in the same test run, which should allow us to launch containers for all databases in the same CI job (assuming CI VM resource limits permit that).
For that to be implemented however, the current workaround of passing DB versions via env var needs to be replaced.
Due to doing even more changes to the service containers with this it may be worth to just not use service containers at all in the future, launching custom containers by ourselves at an early step.
That may also benefit testing on other OS, as service containers are currently only supported on ubuntu.
Are there changes in behavior for the user?
No.
Related issue number
Fixes #664
Checklist
CHANGES.txt