-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated Pool.get #706
Conversation
7c6d581
to
4992883
Compare
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
- Coverage 92.72% 92.62% -0.11%
==========================================
Files 38 38
Lines 5570 5560 -10
Branches 944 941 -3
==========================================
- Hits 5165 5150 -15
- Misses 317 322 +5
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
based on the coverage report it should also be safe to remove when we add type annotations we can probably merge the various context managers into a single one like in aio-libs/aiopg#813 anyways. |
8459477
to
2239d89
Compare
2239d89
to
ace173a
Compare
ace173a
to
798e7fd
Compare
What do these changes do?
Deprecated method
Pool.get
was removedAre there changes in behavior for the user?
Yes, see above.
Related issue number
no
Checklist
CHANGES.txt