Context Manager rollback/commit on aexit #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jettify
reviewed
Aug 2, 2018
tests/test_pool.py
Outdated
| from pyodbc import Error | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_create_pool(loop, pool_maker, dsn): |
There was a problem hiding this comment.
Odd, why github shows diff here?
There was a problem hiding this comment.
Is it possible because of End Of Line difference between Windows and Linux?
There was a problem hiding this comment.
ah, good point, can you please convert to unix end of line?
There was a problem hiding this comment.
I updated the file but still the same issue. Do you have any other ideas?
|
Changes looks good! Need to investigate why github shows diff there |
|
looks good now! thanks! |
|
New version deployed on PyPI https://pypi.org/project/aioodbc/0.3.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to pyodbc when Connection Manager is used the current transaction should be
rollback-ed on error, otherwise commit-ed if autocommit=False